Fix issue #381 #402
Merged
Fix issue #381 #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect this issue is very difficult to reproduce since it fundamentally is a race condition. Maybe it occurs when here are multiple call backs for the same pod but the cache is fundamentally a singleton ? I thought the LRU cache was additionally thread safe but maybe not. I can accept the change and do not see it introducing a regression |
|
Merging as all tests are passing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed Issue #381.
However, since I don't know how to reproduce Issue #381, I haven't been able to confirm the bug.
Therefore, I cannot guarantee that this pull request will completely resolve Issue #381.
That said, I have replaced the implementation with a non-destructive method, so at the very least, it should serve as a refactoring improvement.