Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

NullPointerException while getting list of services has been fixed. #185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

NullPointerException while getting list of services has been fixed. #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...d/hello-hystrix/src/main/java/io/fabric8/kubeflix/examples/hellohystrix/HelloCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class HelloCommand extends HystrixCommand<String> {


protected HelloCommand() {
super(HystrixCommandGroupKey.Factory.asKey("HelloGroup"));
super(HystrixCommandGroupKey.Factory.asKey("HelloRibbonGroup"));
}

@Override
Expand Down
1 change: 1 addition & 0 deletions ribbon-discovery/src/main/java/io/fabric8/kubeflix/ribbon/KubernetesServerList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ public KubernetesServerList(IClientConfig clientConfig, KubernetesClient client)
}

public void initWithNiwsConfig(IClientConfig clientConfig) {
this.client = new DefaultKubernetesClient();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any guarantees that this method will be called only when the object is constructed using the empty constructor? If not, then it can potentially be an issue.

It would be cleaner if we took care of the problem as part of the default constructor.

Copy link
Contributor Author

@irbis irbis Sep 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I tested this, first default constructor runs, then initWithNiwsConfig(). I didn't see any call to other variants of constructors.

To guarantee from issues why not to add check to null:
if (this.client == null) this.client = new DefaultKubernetesClient();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just move the logic to the default constructor? I think that this is the cleanest possible approach.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did it. But it didn't work. I could check why, but I need extra time for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only rational explanation I can think of is the default constructor not being used at all. It could use the non-default ones and pass a null instance of the kubernetes-client.

Copy link
Contributor Author

@irbis irbis Sep 11, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Give me a couple of days and I'll attach stack trace.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I've checked the code and find out some changes were added after I had created PR. Let's drop my changes.

Thanks

this.clientConfig = clientConfig;
this.name = clientConfig.getClientName();
this.namespace = clientConfig.getPropertyAsString(KubernetesConfigKey.Namespace, client.getNamespace());
Expand Down