test: fix Sonar smells in CRD generator tests

Signed-off-by: David Sondermann <[email protected]>
fabric8io · Nov 28, 2024 · ffdd4f9 · ffdd4f9
1 parent 5054cda
commit ffdd4f9
Show file tree

Hide file tree

Showing 2 changed files with 268 additions and 330 deletions.
diff --git a/java-generator/core/src/test/java/io/fabric8/java/generator/CompilationTest.java b/java-generator/core/src/test/java/io/fabric8/java/generator/CompilationTest.java
@@ -119,13 +119,13 @@ void testCalicoIPPoolCRDDoesNotCompileWhenDuplicatesAreNotDeprecated() throws Ex
     config = config.toBuilder()
         .objectExtraAnnotations(true)
         .build();
+    final var fileJavaGenerator = new FileJavaGenerator(config, crd);
 
     // Assert
-    assertThatThrownBy(() -> {
-      // Act
-      new FileJavaGenerator(config, crd).run(tempDir);
-      javac().compile(getSources(tempDir));
-    }).as("The current CRD should not compile since it contains duplicate fields which are not marked as deprecated")
+    assertThatThrownBy(
+        // Act
+        () -> fileJavaGenerator.run(tempDir))
+        .as("The current CRD should not compile since it contains duplicate fields which are not marked as deprecated")
         .isInstanceOf(JavaGeneratorException.class);
   }