Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use JsonFormat shape in crd-generator and java-generator #5917

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Use JsonFormat shape in crd-generator and java-generator #5917

merged 1 commit into from
Apr 24, 2024

Conversation

matteriben
Copy link
Contributor

@matteriben matteriben commented Apr 18, 2024 •
edited
Loading

Description

Fixes #5867

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@matteriben
Copy link
Contributor Author

@andreaTP Please take a look at this.

andreaTP
andreaTP approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement!
LGTM

@matteriben matteriben marked this pull request as draft April 18, 2024 15:49
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from 59e305a to 3aa0bb7 Compare April 18, 2024 18:11
@matteriben matteriben mentioned this pull request Apr 18, 2024
Closed
@matteriben matteriben marked this pull request as ready for review April 18, 2024 18:13
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from 3aa0bb7 to 1c30978 Compare April 19, 2024 01:56
manusa
manusa approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 6.13.0 milestone Apr 19, 2024 — with automated-tasks
@manusa
Copy link
Member

manusa commented Apr 19, 2024

@shawkins, is this OK?

@matteriben matteriben marked this pull request as draft April 19, 2024 15:08
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from 1c30978 to 349eff4 Compare April 19, 2024 15:11
@matteriben matteriben marked this pull request as ready for review April 19, 2024 15:19
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from 349eff4 to b946c94 Compare April 19, 2024 15:32
@matteriben matteriben marked this pull request as draft April 19, 2024 16:01
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from b946c94 to a27b732 Compare April 19, 2024 16:06
@matteriben matteriben marked this pull request as ready for review April 19, 2024 16:07
shawkins
shawkins approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@manusa it is in that it fits with current sundrio based approach. If / when we continue down the path of leveraging jackson, then this is reflected in the schema already.

@matteriben matteriben force-pushed the iss_5867_jsonformat branch 2 times, most recently from 1bf8006 to 9f4a1c6 Compare April 23, 2024 15:48
@matteriben matteriben force-pushed the iss_5867_jsonformat branch from 9f4a1c6 to 987a103 Compare April 23, 2024 17:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@manusa manusa merged commit a8fba97 into fabric8io:main Apr 24, 2024
20 checks passed
@msvticket
Copy link

This PR claims to be fixing #5867 whose title is: Generate a CRD with {type: string, format: date-time}
I don't see how this PR fixes that. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

@shawkins shawkins shawkins approved these changes

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@sunix sunix Awaiting requested review from sunix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.13.0
Development

Successfully merging this pull request may close these issues.

Generate a CRD with {type: string, format: date-time}
5 participants
@matteriben @manusa @msvticket @shawkins @andreaTP