refactor: openshift-model-monitoring generated from OpenAPI schemas #6368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manusa
requested review from
oscerd,
rohanKanojia and
shawkins
as code owners
manusa
force-pushed
the
refactor/openshift-model-monitoring
branch
2 times, most recently
from
1d95fac
to
1ff7c61
Compare
oscerd
approved these changes
Sep 24, 2024
manusa
force-pushed
the
refactor/openshift-model-monitoring
branch
2 times, most recently
from
8aacb0c
to
4c39577
Compare
Signed-off-by: Marc Nuri <[email protected]>
manusa
force-pushed
the
refactor/openshift-model-monitoring
branch
from
4c39577
to
7127ec8
Compare
|
| @@ -32,8 +32,8 @@ | |||
| import io.fabric8.openshift.api.model.monitoring.v1.ServiceMonitorList; | |||
| import io.fabric8.openshift.api.model.monitoring.v1.ThanosRuler; | |||
| import io.fabric8.openshift.api.model.monitoring.v1.ThanosRulerList; | |||
| import io.fabric8.openshift.api.model.monitoring.v1alpha1.AlertmanagerConfig; | |||
| import io.fabric8.openshift.api.model.monitoring.v1alpha1.AlertmanagerConfigList; | |||
There was a problem hiding this comment.
Shall we add an entry for deletion of v1alpha1 group in https://github.com/fabric8io/kubernetes-client/blob/main/doc/MIGRATION-v7.md#model-changes ?
rohanKanojia
approved these changes
Sep 26, 2024
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6269
Type of change
test, version modification, documentation, etc.)
Checklist