Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable configuring of categories in CRD generation #6457

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Enable configuring of categories in CRD generation #6457

wants to merge 3 commits into from
+67 −2

Conversation

MichaelMorrisEst
Copy link

Description

Adds a new annotation @Categories that enables users of the CRD generator to set categories in the generated CRD.

Closes #5795

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@MichaelMorrisEst MichaelMorrisEst marked this pull request as ready for review October 31, 2024 12:01
baloo42
baloo42 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@baloo42 baloo42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

metacosm
metacosm approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baloo42 baloo42 baloo42 approved these changes

@metacosm metacosm metacosm approved these changes

@andreaTP andreaTP Awaiting requested review from andreaTP andreaTP is a code owner

@manusa manusa Awaiting requested review from manusa manusa is a code owner

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRDGenerator: Allow to configure categories
3 participants
@MichaelMorrisEst @metacosm @baloo42