test(): text dnd #9112

ShaMan123 · 2023-07-20T08:41:29Z

Motivation

Testing the formerly untestable drag and drop feature.
After a lot of hours I finally managed to get it to work.
Eraser is next
Playwright is powerful - it was a very good decision

Description

Changes

removed e2e/imports.ts in favor of a full importmap produced in runtime
made babelrc esm
added tests

Gist

In Action

…ic.js into ci-e2e-rel-imports

actions/setup-node#214 (comment) npm/npm#19788

abs resolution + default imports

Revert "Update setupApp.ts" This reverts commit 5dcd615.

commit 1849a03 Author: ShaMan123 <[email protected]> Date: Thu Jul 20 01:15:16 2023 +0530 Update playwright.config.ts commit fd4102f Author: ShaMan123 <[email protected]> Date: Wed Jul 19 23:19:45 2023 +0530 Update setupApp.ts Revert "Update setupApp.ts" This reverts commit 5dcd615. commit ec4ac28 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:38:04 2023 +0530 fix transforming error commit b7edf37 Merge: 3aaa04b 73fa847 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:31:09 2023 +0530 Merge branch 'master' into ci-e2e-rel-imports commit 3aaa04b Author: ShaMan123 <[email protected]> Date: Wed Jul 19 22:23:19 2023 +0530 cleanup commit ced8451 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 17:21:54 2023 +0530 abs resolution + default imports abs resolution + default imports commit 4f7bda2 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 15:08:58 2023 +0530 cleanup commit 47b954f Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:38:09 2023 +0530 node version - this was supposed to throw commit 6ccd23c Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:33:35 2023 +0530 try to fix node14 ci error actions/setup-node#214 (comment) npm/npm#19788 commit cb31f22 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 14:09:57 2023 +0530 Update package-lock.json commit 248d0be Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:59:48 2023 +0530 forgot the setup commit 19e20d3 Merge: b9c0da6 f09a52e Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:54:49 2023 +0530 Merge branch 'ci-e2e-rel-imports' of https://github.com/fabricjs/fabric.js into ci-e2e-rel-imports commit b9c0da6 Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:54:25 2023 +0530 extends commit f09a52e Author: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Date: Wed Jul 19 08:22:08 2023 +0000 update CHANGELOG.md commit 20b9eaa Author: ShaMan123 <[email protected]> Date: Wed Jul 19 13:49:28 2023 +0530 ci(e2e): support relative imports

github-actions · 2023-07-20T08:43:13Z

Build Stats

file / KB (diff)	bundled	minified
fabric	915.042 (0)	305.411 (0)

ShaMan123

removed e2e/imports.ts in favor of a full importmap produced in runtime
made babelrc esm

github-actions · 2023-07-29T19:26:24Z

Coverage after merging test-text-dnd into master will be

82.97%

Coverage Report

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
index.node.ts	7.69%	100%	0%	14.29%	17, 20, 23, 35, 38, 41
src
ClassRegistry.ts	100%	100%	100%	100%
Collection.ts	94.71%	94.64%	86.67%	97.09%	101, 104, 207–208, 233–234
CommonMethods.ts	96.55%	87.50%	100%	100%	9
Intersection.ts	100%	100%	100%	100%
Observable.ts	87.76%	85.29%	87.50%	89.58%	134–135, 160–161, 32–33, 41, 50, 78, 89
Point.ts	100%	100%	100%	100%
Shadow.ts	98.36%	95.65%	100%	100%	178
cache.ts	97.06%	90%	100%	100%	57
config.ts	75%	66.67%	66.67%	82.76%	130, 138, 138, 138, 138, 138–140, 151–153
constants.ts	100%	100%	100%	100%
src/Pattern
Pattern.ts	92.31%	91.89%	90%	93.55%	118, 129, 138, 31, 94
src/brushes
BaseBrush.ts	100%	100%	100%	100%
CircleBrush.ts	0%	0%	0%	0%	108, 108, 108, 110, 112, 114–116, 118–121, 128–129, 13, 136, 138, 23–24, 32–36, 40–44, 51–54, 62–66, 68, 76, 76, 76, 76, 76–77, 79, 79, 79–82, 84, 92–93, 95, 97–99
PatternBrush.ts	97.06%	87.50%	100%	100%	21
PencilBrush.ts	91.06%	82.35%	100%	93.81%	122–123, 152, 152–154, 176, 176, 276, 280, 285–286, 68–69, 84–85
SprayBrush.ts	0%	0%	0%	0%	107, 107, 107, 107, 107–108, 110–111, 118–119, 121, 123–127, 136, 140–141, 141, 149, 149, 149–152, 154–157, 161–162, 164, 166–169, 17, 172, 179, 18, 180, 182, 184–185, 187, 194–195, 197–198, 20, 201, 201, 208, 208, 21, 212, 22, 22, 22–24, 28, 32, 39, 46, 53, 60, 67, 84–86, 94–96, 98–99
src/canvas
Canvas.ts	79.12%	77.68%	83.05%	79.61%	1000, 1003–1004, 1004, 1004, 1006, 1014, 1014, 1014–1016, 1016, 1016, 1023–1024, 1032–1033, 1033, 1033–1034, 1040, 1042, 1073–1075, 1078–1079, 1083–1084, 1197–1199, 1202–1203, 1276, 1395, 1517, 157, 182, 292–293, 296–300, 305, 328–329, 334–339, 359, 359, 359–360, 360, 360–361, 369, 37, 374–375, 375, 375–376, 378, 387, 393–394, 394, 394, 41, 437, 445, 449, 449, 449–450, 452, 535–536, 536, 536–537, 543, 543, 543–545, 565, 567, 567, 567–568, 568, 568, 571, 571, 571–572, 575, 584–585, 587–588, 590, 590–591, 593–594, 606–607, 607, 607–608, 610–615, 621, 628, 665, 665, 665, 667, 669–674, 680, 686, 686, 686–687, 689, 692, 697, 710, 738, 738, 796–797, 797, 797–798, 800, 803–804, 804, 804–805, 807–808, 811, 811–813, 816–817, 887, 899, 906, 927, 959, 980–981, 997–998, 998, 998–999
CanvasOptions.ts	100%	100%	100%	100%
SelectableCanvas.ts	94.44%	92.28%	94.23%	96.17%	1098, 1100, 1102–1103, 301, 477–478, 480–481, 481, 481, 530–531, 592–593, 646–648, 680, 685–686, 713–714, 898, 898–899, 902, 922, 922, 971, 979
StaticCanvas.ts	96.78%	93.09%	100%	98.53%	1030, 1040, 1092–1093, 1096, 1131–1132, 1208, 1217, 1217, 1221, 1221, 1268–1269, 185–186, 202, 570, 582–583, 913–914, 914, 914–915
StaticCanvasOptions.ts	100%	100%	100%	100%
TextEditingManager.ts	84.31%	71.43%	91.67%	88%	17–18, 18, 18–19, 19, 19
src/canvas/DOMManagers
CanvasDOMManager.ts	95.52%	70%	100%	100%	21–22, 29
StaticCanvasDOMManager.ts	100%	100%	100%	100%
util.ts	86.67%	80.56%	83.33%	93.94%	14, 26, 63–64, 67, 67, 74, 93–94
src/color
Color.ts	94.96%	91.67%	96.30%	96.05%	233, 258–259, 267–268, 48
color_map.ts	100%	100%	100%	100%
constants.ts	100%	100%	100%	100%
util.ts	85.71%	76.92%	100%	89.74%	55–56, 56, 58, 58, 58–59, 61–62, 89
src/controls
Control.ts	93.33%	87.88%	91.67%	97.78%	175, 240, 327, 327, 362
changeWidth.ts	100%	100%	100%	100%
commonControls.ts	100%	100%	100%	100%
controlRendering.ts	81.63%	78%	100%	84.78%	106, 111, 121, 121, 45, 50, 61, 61, 65–72, 81–82
drag.ts	100%	100%	100%	100%
fireEvent.ts	88.89%	75%	100%	100%	13
polyControl.ts	6.06%	0%	0%	11.43%	103, 117, 117, 117, 117, 117, 119–122, 122, 125, 132, 17, 25–29, 29, 29, 29, 29, 29, 29, 29, 50–56, 56, 56, 56, 56, 58, 63–64, 66, 76, 82–84, 84, 86, 89–90, 90, 90, 90, 90, 92, 97
rotate.ts	19.57%	12.50%	50%	21.43%	41, 45, 51, 51, 51–52, 55–57, 59, 59, 59, 59, 59–61, 61, 61–63, 65, 65, 65–67, 67, 67–68, 73, 73, 73–74, 76, 78, 80–81
scale.ts	93.57%	92.94%	100%	93.67%	129–130, 132–134, 148–149, 181–183, 42
scaleSkew.ts	78.79%	64.29%	100%	85.71%	27, 29, 29, 29, 31, 33, 35
skew.ts	91.03%	79.31%	100%	97.67%	131–132, 163–164, 171, 177, 179
util.ts	100%	100%	100%	100%
wrapWithFireEvent.ts	100%	100%	100%	100%
wrapWithFixedAnchor.ts	100%	100%	100%	100%
src/env
browser.ts	<

ShaMan123 · 2023-07-29T19:46:33Z

e2e/tests/text/drag&drop/index.spec.ts

+  // we need to fix font diff
+  process.env.CI && test.fail();


disabled the error for now

ShaMan123 · 2023-07-29T19:46:59Z

e2e/setup/setupCoverage.ts

+        !coverageIgnore.some((ignore) =>
+          pathTo.startsWith(path.resolve(process.cwd(), ignore))


ignoring unnecessary coverage data

ShaMan123 · 2023-07-29T19:47:33Z

I think we can merge this and get back to the font inconsistency

ShaMan123

Implemented font caching for perf
I can extract the changes to the test suite to another PR if you want

ShaMan123

READY
Not touching anymore

asturur · 2023-08-30T19:20:26Z

@ShaMan123 i'm merging the dnd test but making it font independent.
For font loading we can't rely on network connections to google fonts. For how much stable they can be we need to limit to local assets. We can make the font local assets and load them from localhost as soon as there is a real necessity.

asturur · 2023-08-30T20:37:03Z

great test

ShaMan123 · 2023-08-31T02:39:00Z

I wish you not delete setupFonts and setupImports
Why remove setupImports? It is super light weight and makes the test files behave as any module
And for setupFonts, can you leave it there but not import it so we don't need to redo it with a comment or whatever for the future?

asturur · 2023-08-31T07:01:58Z

i didn't delete them, are in a backup branch.
test-text-dnd-previous

setupImports was added to add fontObserver? The test work without the change, so the change wasn't needed.
there was no explanation of what setupImports did apart removed e2e/imports.ts in favor of a full importmap produced in runtime is completely unclear why to do that since all test were running fine without.
The moment we need a second import outside fabric in a test we can add it.

setupFonts wasn't good imho It used google fonts and used fontFaceObserver, and i don't want to use either of them.
it had network dependencies on tests, fiddling with google css, network intercepting to make custom chaching. we shouldn't deal with those things. As soon as we need a custom font for a test that is not Arial we can add the font to the repo and load it from localhost using the standard browser api

ShaMan123 and others added 24 commits July 19, 2023 13:49

ci(e2e): support relative imports

20b9eaa

update CHANGELOG.md

f09a52e

extends

b9c0da6

Merge branch 'ci-e2e-rel-imports' of https://github.com/fabricjs/fabr…

19e20d3

…ic.js into ci-e2e-rel-imports

forgot the setup

248d0be

Update package-lock.json

cb31f22

try to fix node14 ci error

6ccd23c

actions/setup-node#214 (comment) npm/npm#19788

node version - this was supposed to throw

47b954f

cleanup

4f7bda2

abs resolution + default imports

ced8451

abs resolution + default imports

cleanup

3aaa04b

Merge branch 'master' into ci-e2e-rel-imports

b7edf37

fix transforming error

ec4ac28

Update setupApp.ts

fd4102f

Revert "Update setupApp.ts" This reverts commit 5dcd615.

Update playwright.config.ts

1849a03

Create index.spec.ts

450764d

progress@#

c101221

Update index.spec.ts

e1079a9

working

5622cd6

Update test.ts

505fb09

GRAET!

b58e386

matchers

2005d49

better before + types

1d635eb

ShaMan123 added the CI/CD label Jul 20, 2023

ShaMan123 requested a review from asturur July 20, 2023 08:41

ShaMan123 added 3 commits July 20, 2023 14:20

Update index.ts

3899f8c

Merge branch 'ci-e2e-rel-imports' into test-text-dnd

5a43c4f

Update playwright.config.ts

7b1dde5

ShaMan123 added 2 commits July 30, 2023 00:36

cleanup

200d257

cleanup

070e604

ShaMan123 commented Jul 29, 2023

View reviewed changes

Update index.spec.ts

fbcbba4

Update setupCoverage.ts

8262290

ShaMan123 commented Jul 29, 2023

View reviewed changes

ShaMan123 added 4 commits July 30, 2023 10:15

font caching!

db51377

cleanup

1e5a946

ws

e994159

Update .prettierignore

9c908d8

ShaMan123 commented Jul 30, 2023

View reviewed changes

ShaMan123 added 2 commits July 30, 2023 10:31

Update index.spec.ts

2a4e26f

better messages

8d7ad6a

ShaMan123 commented Jul 30, 2023

View reviewed changes

ShaMan123 mentioned this pull request Jul 30, 2023

ci(e2e): node canvas visual tests #9134

Merged

2 tasks

ShaMan123 mentioned this pull request Aug 30, 2023

feat(Node): pdf/svg output #9185

Open

asturur added 2 commits August 30, 2023 20:56

Merge branch 'master' into test-text-dnd

d9be1de

prettier from master merge

602d4f6

asturur added 3 commits August 30, 2023 21:25

remove font family

0df6774

removed extra font code

7cabf6a

test passing

ee3d614

asturur approved these changes Aug 30, 2023

View reviewed changes

asturur merged commit 14a4b7b into master Aug 30, 2023
24 checks passed

asturur deleted the test-text-dnd branch August 30, 2023 20:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(): text dnd #9112

test(): text dnd #9112

ShaMan123 commented Jul 20, 2023 •

edited

Loading

github-actions bot commented Jul 20, 2023 •

edited

Loading

ShaMan123 left a comment

github-actions bot commented Jul 29, 2023 •

edited

Loading

ShaMan123 Jul 29, 2023

ShaMan123 Jul 29, 2023

ShaMan123 commented Jul 29, 2023

ShaMan123 left a comment •

edited

Loading

ShaMan123 left a comment

asturur commented Aug 30, 2023

asturur commented Aug 30, 2023

ShaMan123 commented Aug 31, 2023 •

edited

Loading

asturur commented Aug 31, 2023

		!coverageIgnore.some((ignore) =>
		pathTo.startsWith(path.resolve(process.cwd(), ignore))

test(): text dnd #9112

test(): text dnd #9112

Conversation

ShaMan123 commented Jul 20, 2023 • edited Loading

Motivation

Description

Changes

Gist

In Action

github-actions bot commented Jul 20, 2023 • edited Loading

ShaMan123 left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 29, 2023 • edited Loading

ShaMan123 Jul 29, 2023

Choose a reason for hiding this comment

ShaMan123 Jul 29, 2023

Choose a reason for hiding this comment

ShaMan123 commented Jul 29, 2023

ShaMan123 left a comment • edited Loading

Choose a reason for hiding this comment

ShaMan123 left a comment

Choose a reason for hiding this comment

asturur commented Aug 30, 2023

asturur commented Aug 30, 2023

ShaMan123 commented Aug 31, 2023 • edited Loading

asturur commented Aug 31, 2023

ShaMan123 commented Jul 20, 2023 •

edited

Loading

github-actions bot commented Jul 20, 2023 •

edited

Loading

github-actions bot commented Jul 29, 2023 •

edited

Loading

ShaMan123 left a comment •

edited

Loading

ShaMan123 commented Aug 31, 2023 •

edited

Loading