-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L2 genesis generation w/ predeploy #240
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. optimism creates the deployment artifacts for the L1 and L2 contracts with solidity, is this a follow-up we'd want to implement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lightly reviewed the OP code, but everything else LGTM. Let me know if you want me to look in more detail at the OPs code.
Yes ideally we want to shift most complex bash scripts to golang/python and consolidate all configurations/deployment in one program |
@@ -0,0 +1,20 @@ | |||
# Ops |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we move ops
into either services
or lib
(whichever is more appropriate) -- want to try keeping the root dir minimal
@@ -0,0 +1,3 @@ | |||
build | |||
bindings/bindings/*.go | |||
!bindings/bindings/registry.go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: whats the !
and is this file not covered by the ignored path above
Goals of PR
Core changes:
op-bindings
andop-chain-ops
packagesops/bindings
: Predeploy and proxy contract bindings generation with deployed bytecode and storage layoutops/cmd/genesis
: Introduce a new command which reads aGenesisConfig
(seeops/genesis/config.go
) and generate a geth genesis file by deploying predeploys on a simulated backend and transform deployment information into genesis file.TODOs: