Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bash linting worklow #244

Merged
merged 9 commits into from
Nov 29, 2023
Merged

add bash linting worklow #244

merged 9 commits into from
Nov 29, 2023

Conversation

siosw
Copy link
Contributor

@siosw siosw commented Nov 24, 2023

Goals of PR

improve the code quality in sbin/

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8c473a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siosw siosw changed the base branch from develop to siosw/env-docs November 24, 2023 11:40
@siosw siosw force-pushed the siosw/sbin-lint branch 3 times, most recently from d45fc81 to dfff089 Compare November 24, 2023 11:46
@siosw siosw mentioned this pull request Nov 28, 2023
Merged
Base automatically changed from siosw/env-docs to develop November 28, 2023 19:30
@siosw siosw marked this pull request as ready for review November 28, 2023 21:02
@siosw siosw force-pushed the siosw/sbin-lint branch 2 times, most recently from 3b87e55 to 34453fc Compare November 28, 2023 21:08
@ujvl ujvl merged commit 13f6684 into develop Nov 29, 2023
5 checks passed
@ujvl ujvl deleted the siosw/sbin-lint branch November 29, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macwis macwis macwis approved these changes

@ujvl ujvl ujvl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siosw @macwis @ujvl