Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configs for watcher delay #321

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

chalkandpaste
Copy link
Contributor

@chalkandpaste chalkandpaste commented Feb 6, 2024

Goals of PR

Core changes:

  • Implements configuration parameters for the new ChainWatcher delay parameter which allows for configurable rate limiting in checking for new L1 blocks

Notes:

  • Be careful with the e2e parameter because we test with a block rate of 2s

Copy link

changeset-bot bot commented Feb 6, 2024

⚠️ No Changeset found

Latest commit: 7e6a482

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@rhoop rhoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -22,3 +22,4 @@ DEVNET=true
SEQUENCER=true
SEQUENCER_MAX_SAFE_LAG=200
SEQUENCER_PK_FILE=./sequencer_pk.txt
WATCHER_DELAY=4000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a comment above this (this makes it look like it's a required param for sequencing)

@chalkandpaste chalkandpaste merged commit aef441d into develop Feb 6, 2024
10 of 11 checks passed
@chalkandpaste chalkandpaste deleted the ch/config-watcher-delay branch February 6, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants