Add pending logging

lib/ferrum/browser/client.rb

@@ -43,7 +43,7 @@ def command(method, params = {})
         @pendings.delete(message[:id])
 
         raise DeadBrowserError if data.nil? && @ws.messages.closed?
-        raise TimeoutError unless data
+        raise TimeoutError.new() unless data
 
         error, response = data.values_at("error", "result")
         raise_browser_error(error) if error

lib/ferrum/errors.rb

@@ -27,11 +27,17 @@ def initialize(url, pendings = [])
   end
 
   class TimeoutError < Error
-    def message
-      "Timed out waiting for response. It's possible that this happened " \
-        "because something took a very long time (for example a page load " \
-        "was slow). If so, setting the :timeout option to a higher value might " \
-        "help."
+    attr_reader :pending_urls
+
+    def initialize(pending_urls = [])
+      @pending_urls = pending_urls
+
+      message = "Timed out waiting for response. It's possible that this happened " \
+                "because something took a very long time (for example a page load " \
+                "was slow). If so, setting the :timeout option to a higher value might " \
+                "help."
+      message = "#{message}\n Connections still pending:\n #{pending_urls.join(', ')}" unless pending_urls.empty?
+      super(message)
     end
   end
 

lib/ferrum/network.rb

@@ -62,7 +62,14 @@ def wait_for_idle(connections: 0, duration: 0.05, timeout: @page.browser.timeout
       start = Utils::ElapsedTime.monotonic_time
 
       until idle?(connections)
-        raise TimeoutError if Utils::ElapsedTime.timeout?(start, timeout)
+        if Utils::ElapsedTime.timeout?(start, timeout)
+          if @page.browser.options.pending_connection_errors
+            pendings = traffic.select(&:pending?)
+            pending_urls = pendings.map(&:url).compact
+            puts("[DEBUG] 'wait_for_idle' pending connections:\n#{pendings.map(&:inspect)}")
+          end
+          raise TimeoutError.new(pending_urls = pending_urls)
+        end
 
         sleep(duration)
       end

lib/ferrum/page.rb

@@ -282,7 +282,7 @@ def command(method, wait: 0, slowmoable: false, **params)
         @event.wait(wait)
         if iteration != @event.iteration
           set = @event.wait(timeout)
-          raise TimeoutError unless set
+          raise TimeoutError.new() unless set
         end
       end
       result