Skip to content

Commit

Permalink
Fix test_sqa_storage_map_metric_experiment (#2297)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2297

lena-kashtelyan could I get your help debugging this? This test is currently flaky on prod with errors like "8 is not greater than 10" etc -- are we really sure we should get twice as many calls than there are trials?

Reviewed By: lena-kashtelyan

Differential Revision: D55254148

fbshipit-source-id: deb5cfd202d6d8689040f94d5aa68fd3a9dee0d7
  • Loading branch information
mpolson64 authored and facebook-github-bot committed Mar 25, 2024
1 parent 87bf0ca commit d120362
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ax/service/tests/scheduler_test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ def test_sqa_storage_map_metric_experiment(self) -> None:
# We also should have attempted the fetch more times
# than there are trials because we have a `MapMetric` (many more since we are
# waiting 3 seconds for each trial).
self.assertGreater(mock_experiment_attach_data.call_count, NUM_TRIALS * 2)
self.assertGreater(mock_experiment_attach_data.call_count, NUM_TRIALS)

# Check that it's the last-attached data that was kept, using
# expected value based on logic in mocked "current_timestamp_in_millis"
Expand Down

0 comments on commit d120362

Please sign in to comment.