Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_optimal sometimes being used for y_metric_name #2849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix is_optimal sometimes being used for y_metric_name #2849

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. Fix is_optimal sometimes being used for y_metric_name 

    Summary:
When generating the plot the y_metric name is inferred based on the other columns expected to be. When is_optimal was added this needed to be updated as well.

Now, instead of inferring we're just going to supply the y metric name directly -- this should be less error prone.

Differential Revision: D64123183
    @mpolson64 @facebook-github-bot
    mpolson64 authored and facebook-github-bot committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    2546c29 View commit details
    Browse the repository at this point in the history