Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow updating of opt config on completion events #2961

Closed

Conversation

danielcohenlive
Copy link

Summary: This will allow for accuracy in human in the loop experiments where metrics change through the lifecycle of experiments.

Differential Revision: D61996011

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 24, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61996011

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.61%. Comparing base (6716e1e) to head (26d75f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2961   +/-   ##
=======================================
  Coverage   95.61%   95.61%           
=======================================
  Files         485      485           
  Lines       48980    48986    +6     
=======================================
+ Hits        46831    46837    +6     
  Misses       2149     2149           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Oct 30, 2024
Summary:

This will allow for accuracy in human in the loop experiments where metrics change through the lifecycle of experiments.

Reviewed By: mgarrard

Differential Revision: D61996011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61996011

Summary:

This will allow for accuracy in human in the loop experiments where metrics change through the lifecycle of experiments.

Reviewed By: mgarrard

Differential Revision: D61996011
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D61996011

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 95dceca.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants