Don't pass unused arguments to optimizer_argparse
#2999
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65233328 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2999 +/- ##
==========================================
- Coverage 95.60% 95.60% -0.01%
==========================================
Files 483 483
Lines 49007 48971 -36
==========================================
- Hits 46855 46820 -35
+ Misses 2152 2151 -1 ☔ View full report in Codecov by Sentry. |
Summary: Context: It appears that using `qKnowledgeGradient` with MBM doesn't work, since [this line](https://github.com/facebook/Ax/blob/535af4edff70cbf20a49c676377f5c8945560d03/ax/models/torch/botorch_modular/acquisition.py#L339) passes the argument `optimizer` to `_argparse_kg`, which errors [here](https://github.com/facebook/Ax/blob/535af4edff70cbf20a49c676377f5c8945560d03/ax/models/torch/botorch_modular/optimizer_argparse.py#L169) because it has now received the argument "optimizer" twice. We don't really need the `optimizer_argparse` special case for qKG anymore. This existed for two reasons: - in order to construct initial conditions, which can be handled by `optimize_acqf`, and - to ensure that the optimizer is `optimize_acqf`, because others are not supported This diff: * Modifies the `optimize_argparse` case for qKG to do nothing except update the optimizer to `optimize_acqf` and then call the base case Implementation notes: * Isn't it nonintuitive to set the optimizer then override it? Yes, a little, but the user can't choose the optimizer, so we're not overriding a user-specified choice. Also, lots of arguments to the `optimizer_argparse` functions get ignored. The "right" thing might be to put the choice of optimizer inside a dispatcher so that it can depend on the acquisition class, but that would be a bigger change. * Do we really need this dispatcher anymore, if it is doing so little? Maybe. Third parties may wish to use it to accommodate acquisition functions that are not in Ax. On the other hand, this dispatcher is currently not doing much of anything. * Do the `optimize_argparse` functions still need to support so many arguments, given that some of them seemed to just be there for constructing initial conditions? Probably not; I mean to look into that in a follow-up. Reviewed By: saitcakmak Differential Revision: D65227420
…2998) Summary: Context: This dispatcher's only usage is to raise an exception with qKG. There is no need for it to be a dispatcher. This diff: * makes `optimizer_argparse` no longer a dispatcher * Moves the error for qKG into the body of the now-only `optimizer_argparse` function * Removes special function for qKG * Changes type annotations so that the first argument is always an `AcquisitionFunction`; it was always used that way, with different types used only in tests. Reviewed By: saitcakmak, Balandat Differential Revision: D65231763
Summary: Context: - The only arguments ever passed to `optimizer_argparse` are `acqf`, `optimizer_options`, and `optimizer`, `q`, and `bounds`. The latter two are always ignored. - `optimizer_argparse` accepts a bunch of arguments that are never passed to it... and never should be, because, as the docstring explains, `optimizer_options` is the right place to pass those. Reviewed By: saitcakmak, Balandat Differential Revision: D65233328
esantorella
force-pushed
the
export-D65233328
branch
from
18cd164
to
c0da6fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65233328 |
|
This pull request has been merged in a9a9a7c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context:
optimizer_argparseareacqf,optimizer_options, andoptimizer,q, andbounds. The latter two are always ignored.optimizer_argparseaccepts a bunch of arguments that are never passed to it... and never should be, because, as the docstring explains,optimizer_optionsis the right place to pass those.Reviewed By: saitcakmak, Balandat
Differential Revision: D65233328