Support per-metric model specification in MBM #3009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Enables using different models for different metrics. * Adds ModelConfig dataclass to specify a single botorch model configuration * Adds a list of ModelConfigs to SurrogateSpec * Adds a dictionary mapping metric names to list of ModelConfigs to enable per-metric model specification * Lists of model configs are used to enable per-metric model selection across multiple ModelConfigs in a subsequent diff. Reviewed By: saitcakmak Differential Revision: D64793595
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64793595 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3009 +/- ##
=======================================
Coverage 95.60% 95.60%
=======================================
Files 483 483
Lines 48907 48989 +82
=======================================
+ Hits 46758 46837 +79
- Misses 2149 2152 +3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Enables using different models for different metrics.
Reviewed By: saitcakmak
Differential Revision: D64793595