Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors loading last GR state with reduced_state #3011

Closed

Conversation

danielcohenlive
Copy link

Summary: If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Differential Revision: D65350559

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 1, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65350559

@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.60%. Comparing base (d3dd862) to head (1adda28).

Files with missing lines Patch % Lines
ax/storage/sqa_store/decoder.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3011      +/-   ##
==========================================
- Coverage   95.60%   95.60%   -0.01%     
==========================================
  Files         483      483              
  Lines       48942    48963      +21     
==========================================
+ Hits        46793    46813      +20     
- Misses       2149     2150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Differential Revision: D65350559
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Differential Revision: D65350559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65350559

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65350559

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Differential Revision: D65350559
danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Reviewed By: lena-kashtelyan

Differential Revision: D65350559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65350559

danielcohenlive pushed a commit to danielcohenlive/Ax-1 that referenced this pull request Nov 1, 2024
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Differential Revision: D65350559

Reviewed By: lena-kashtelyan
Summary:
Pull Request resolved: facebook#3011

If we're using reduced state and getting an error because the last GR doesn't use reduced state, try with reduced state

Reviewed By: lena-kashtelyan

Differential Revision: D65350559
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65350559

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 16440d2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants