Deprecate Models.GPEI registry entry #3020
Closed
+28
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Factory functions mostly duplicate an existing registry entry and are not recommended. This diff cleans up `get_GPEI` factory function, which re-packages legacy GPEI. Differential Revision: D65486831
Summary: This diff deprecates `Models.GPEI`, which has been the default model used in many places in the past. I cleaned up all usage I could find, and updated `Models.GPEI` to point to `Models.BOTORCH_MODULAR` with a deprecation warning. At a later date, we can clean that up with a storage level change to support backwards compatibility to ensure we can continue loading old experiments. Differential Revision: D64987622
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64987622 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3020 +/- ##
==========================================
- Coverage 95.61% 95.60% -0.01%
==========================================
Files 483 483
Lines 49032 49012 -20
==========================================
- Hits 46880 46859 -21
- Misses 2152 2153 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 93c236e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff deprecates
Models.GPEI, which has been the default model used in many places in the past. I cleaned up all usage I could find, and updatedModels.GPEIto point toModels.BOTORCH_MODULARwith a deprecation warning. At a later date, we can clean that up with a storage level change to support backwards compatibility to ensure we can continue loading old experiments.Differential Revision: D64987622