minerva-ag: Fix unexpected sleep at init #2146
Open
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. (Because this pull request was imported automatically, there will not be any future comments.) |
Victor-Jhong
force-pushed
the
minerva-ag/fix_unexpected_sleep_at_init
branch
from
4fafa78 to
0c51c4b
Compare
|
@Victor-Jhong has updated the pull request. You must reimport the pull request before landing. |
jagpalgill
requested changes
Dec 27, 2024
| @@ -184,6 +184,6 @@ void init_cpld_polling(void) | |||
| cpld_polling_tid = k_thread_create( | |||
| &cpld_polling_thread, cpld_polling_stack, K_THREAD_STACK_SIZEOF(cpld_polling_stack), | |||
| poll_cpld_registers, NULL, NULL, NULL, CONFIG_MAIN_THREAD_PRIORITY, 0, | |||
| K_MSEC(3000)); //sleep for 3 seconds to prevent dc status changing when reboot BIC | |||
| K_MSEC(2000)); //sleep for 3 seconds to prevent dc status changing when reboot BIC | |||
There was a problem hiding this comment.
Can you please change the comment as well to reflect 2 instead of 3?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan: