Skip to content

Commit

Permalink
WIP Updates to the ambiguous_crossing_tags validator
Browse files Browse the repository at this point in the history
(re: #1210)

- Handles all types of crossing conflicts and updates, tons of edge cases
- Includes all the entities way/node in a single issue
- Improved UI, code simplification, for the tag conflicts/upgrades
- prefer the shorter name 'ambiguous_crossing' over `ambiguous_crossing_tags`
- candidateCrossing check is still there, but commented out
  • Loading branch information
bhousel committed Dec 19, 2023
1 parent 5c9cd75 commit 7e329f1
Show file tree
Hide file tree
Showing 4 changed files with 446 additions and 429 deletions.
9 changes: 8 additions & 1 deletion css/80_app.css
Original file line number Diff line number Diff line change
Expand Up @@ -3560,7 +3560,9 @@ li.issue-fix-item button:not(.actionable) .fix-icon {
.issue-info.expanded {
display: inline-block;
}

.issue-info .suggested-update {
margin-top: 10px;
}
.issue-info .issue-reference {
margin-bottom: 10px;
}
Expand All @@ -3584,6 +3586,11 @@ li.issue-fix-item button:not(.actionable) .fix-icon {
.issue-info .tagDiff-cell-remove {
background: #fdd;
}
.issue-info .tagDiff-message {
padding: 2px 10px;
font-family: monospace;
font-size: 10px;
}


/* Background - Display Options Sliders
Expand Down
14 changes: 11 additions & 3 deletions data/core.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1829,16 +1829,24 @@ en:
message: "{feature} ends very close to itself but does not reconnect"
highway-highway:
reference: Intersecting highways should share a junction vertex.
ambiguous_crossing_tags:
ambiguous_crossing:
title: Ambiguous Crossing Tags
message: "Line and point disagree about markings"
message_markings: "Line has marking '{marking1}' but point has marking '{marking2}'"
message:
conflict: Crossing line and point tags conflict
update: Crossing tags can be updated
incomplete_message: "Point may be missing crossing information."
incomplete_reference: "Point looks like it may be updated to a crossing."
tip: "Crossing line markings conflict with crossing point"
reference: Line and point must either be both marked or both unmarked.
upgrade_node: "Upgrade point to:"
upgrade_way: "Upgrade way to:"
not_a_crossing: "(not a crossing)"
annotation:
changed: Changed crossing tags
fix:
update_type: "Update tags for a '{type}' crossing"
choose_type: "Tag this crossing as '{type}'"
remove_all: Remove all crossing tags
area_as_point:
message: '{feature} should be an area, not a point'
close_nodes:
Expand Down
Loading

0 comments on commit 7e329f1

Please sign in to comment.