Fix: Prevent re-creation of uiMapRouletteMenu to ensure synchronization

- Resolved issue where uiMapRouletteMenu was being re-created, causing desynchronization with selectMode and UiSystem.
- Ensured that the _qaItem variable is properly defined during menu rendering.
- Improved code stability by maintaining a single instance of uiMapRouletteMenu.

data/core.yaml

@@ -798,7 +798,7 @@ en:
         id_title: Challenge Id / Task Id
         id_placeholder: Challenge IDs
         instruction_title: Instructions
-        fixedIt: I fixed it!
+        fixed: I fixed it!
         cantComplete: Can't Complete
         alreadyFixed: Already Fixed
         notAnIssue: Not an Issue

data/l10n/core.en.json

@@ -1011,7 +1011,7 @@
           "id_title": "Challenge Id / Task Id",
           "id_placeholder": "Challenge IDs",
           "instruction_title": "Instructions",
-          "fixedIt": "I fixed it!",
+          "fixed": "I fixed it!",
           "cantComplete": "Can't Complete",
           "alreadyFixed": "Already Fixed",
           "notAnIssue": "Not an Issue",

modules/modes/SelectMode.js

@@ -158,7 +158,8 @@ export class SelectMode extends AbstractMode {
 
     } else if (datum instanceof QAItem && datum.service === 'maproulette') {
       sidebarContent = uiMapRouletteEditor(context).error(datum);
-      uiMapRouletteMenu(context).error(datum);
+      let uiSystem = this.context.systems.ui;
+      uiSystem.MapRouletteMenu.error(datum);
       sidebarContent
         .on('change', () => {
           gfx.immediateRedraw();  // force a redraw (there is no history change that would otherwise do this)

modules/ui/maproulette_editor.js

@@ -359,7 +359,7 @@ export function uiMapRouletteEditor(context) {
 
       buttonSection.select('.fixedIt-button')
         .attr('disabled', isSaveDisabled(_qaItem))
-        .text(l10n.t('map_data.layers.maproulette.fixedIt'))
+        .text(l10n.t('map_data.layers.maproulette.fixed'))
         .on('click.fixedIt', function(d3_event, d) {
           fixedIt(d3_event, d, selection);
         });
@@ -410,7 +410,6 @@ export function uiMapRouletteEditor(context) {
     const mapRouletteService = context.services.maproulette;
     if (mapRouletteService) {
       mapRouletteService.nearbyTaskEnabled = isChecked;
-      // console.log('Nearby Task feature is now', isChecked ? 'enabled' : 'disabled');
     }
   }