Code

EditSystem modernization#1156

Code

Merged

bhousel merged 41 commits intomainfacebook/Rapid:mainfrom editsystem-modernfacebook/Rapid:editsystem-modernCopy head branch name to clipboardOct 21, 2023

+7,602-5,857

Commits

Commits on Oct 6, 2023

• Encapsulate the edit data in an Edit class

  bhousel

  committed
  cdb3262

  Copy full SHA for cdb3262

• Start to remove the editing operations from context

  Show description for d429e51
  bhousel

  committed
  d429e51

  Copy full SHA for d429e51

• Rename 'data' -> 'dataloader'

  Show description for 8534cb5
  bhousel

  committed
  8534cb5

  Copy full SHA for 8534cb5

• Do a better job capturing the sources used per edit

  Show description for 111dcd7
  bhousel

  committed
  111dcd7

  Copy full SHA for 111dcd7

• Restore missing service: 'mapwithai' prop

  Show description for fda01d9
  bhousel

  committed
  fda01d9

  Copy full SHA for fda01d9

• minor: editor is already available as a variable in scope

  bhousel

  committed
  d34203a

  Copy full SHA for d34203a

• Continuing core refactor, particularly for EditSystem

  Show description for 81017c6
  bhousel

  committed
  81017c6

  Copy full SHA for 81017c6

• Continuing core refactor, particularly for LocalizationSystem

  Show description for 4421c5f
  bhousel

  committed
  4421c5f

  Copy full SHA for 4421c5f

• Few small simplifications in context

  bhousel

  committed
  3fa9d6c

  Copy full SHA for 3fa9d6c

• Move responsibility for saving backups into the EditSystem

  Show description for 508a408
  bhousel

  committed
  508a408

  Copy full SHA for 508a408

• When saving history, save a simplified copy of the entity

  Show description for e31ef31
  bhousel

  committed
  e31ef31

  Copy full SHA for e31ef31

• Drop support for history backup v2, fix tests

  Show description for 7d067b4
  bhousel

  committed
  7d067b4

  Copy full SHA for 7d067b4

• Followup from af7e199, v might not be 0

  Show description for d75d707
  bhousel

  committed
  d75d707

  Copy full SHA for d75d707

• Don't show "are you sure you want to leave" prompt when running tests

  Show description for ab04e93
  bhousel

  committed
  ab04e93

  Copy full SHA for ab04e93

• Can just avoid these event handlers completely if testing

  bhousel

  committed
  acc8090

  Copy full SHA for acc8090

• Pause validating if we are waiting for the user to restore a backup

  bhousel

  committed
  680a90b

  Copy full SHA for 680a90b

• Do a better job loading missing entities when restoring a backup

  Show description for 0a1bf63
  bhousel

  committed
  0a1bf63

  Copy full SHA for 0a1bf63

• Make sure we can exit the walkthrough and still restore history

  Show description for d482059
  bhousel

  committed
  d482059

  Copy full SHA for d482059

• Make sure Difference still works if base === head

  bhousel

  committed
  ddbc019

  Copy full SHA for ddbc019

• WIP: Working towards having separate stable/current edits

  Show description for 0d2ac28
  bhousel

  committed
  0d2ac28

  Copy full SHA for 0d2ac28

• WIP: Replaced the history stack manipulation methods

  Show description for 060fd52
  bhousel

  committed
  060fd52

  Copy full SHA for 060fd52

• WIP: More improvement of EditSystem docs, add diagrams

  Show description for 0466e7f
  bhousel

  committed
  0466e7f

  Copy full SHA for 0466e7f

• Remove unnecessary ActionNoop and calls to validate()

  Show description for a578706
  bhousel

  committed
  a578706

  Copy full SHA for a578706

• Cleanups in ValidationSystem

  Show description for 21336ac
  bhousel

  committed
  21336ac

  Copy full SHA for 21336ac

• Don't warn on unused function arguments

  Show description for 1cde329
  bhousel

  committed
  1cde329

  Copy full SHA for 1cde329

• Continue to improve docs and get strict about event emitters/recievers

  Show description for 75e9fe7
  bhousel

  committed
  75e9fe7

  Copy full SHA for 75e9fe7

• Replace undo/redo with historychange in Move and Rotate modes

  Show description for 161d3f5
  bhousel

  committed
  161d3f5

  Copy full SHA for 161d3f5

• No need to do rollback if there is not work in progress

  Show description for 716b253
  bhousel

  committed
  716b253

  Copy full SHA for 716b253

• A few more conversion from undone/redone -> historychange

  bhousel

  committed
  823ff9d

  Copy full SHA for 823ff9d

Commits on Oct 9, 2023

• Important to dispatch 'merge' when restoring backup history

  Show description for 15f737e
  bhousel

  committed
  15f737e

  Copy full SHA for 15f737e

• Start working towards making mode options serializable

  Show description for 8510314
  bhousel

  committed
  8510314

  Copy full SHA for 8510314

Commits on Oct 10, 2023

• Allow commit to accept options include annotation and selectedIDs

  Show description for ef50d25
  bhousel

  committed
  ef50d25

  Copy full SHA for ef50d25

Commits on Oct 16, 2023

• Better treatment of reselectIDs when dragging

  Show description for c5b4c36
  bhousel

  committed
  c5b4c36

  Copy full SHA for c5b4c36

• More EditSystem cleanup, and fix Draw Modes to survive undo/redo

  Show description for 372e528
  bhousel

  committed
  372e528

  Copy full SHA for 372e528

• ES6ify preset list and restore the hack to allow undo on field focus

  bhousel

  committed
  e5c862a

  Copy full SHA for e5c862a

Commits on Oct 17, 2023

• Make both mouse() and mouseLoc() default to center coordinate

  Show description for 7f6fa04
  bhousel

  committed
  7f6fa04

  Copy full SHA for 7f6fa04

• Cleanup operationExtract, operationPaste, behaviorPaste

  Show description for ca2307d
  bhousel

  committed
  ca2307d

  Copy full SHA for ca2307d

• Restore support for eased edits through EditSystem.performAsync

  Show description for 2ad06df
  bhousel

  committed
  2ad06df

  Copy full SHA for 2ad06df

• Fix typo

  bhousel

  committed
  42fe0cd

  Copy full SHA for 42fe0cd

Commits on Oct 20, 2023

• Restore EditSystem tests

  bhousel

  committed
  6412a1f

  Copy full SHA for 6412a1f

Commits on Oct 21, 2023

• Renames current -> staging, rollback -> revert

  Show description for a8b3e24
  bhousel

  committed
  a8b3e24

  Copy full SHA for a8b3e24