Introduce the end-to-end test harness #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the test harness has been moved from tests/unit/harness to tests/harness, the unit_tests target was still linked to the harness dependencies. Remove the harness dependencies from tests/unit/harness to tests/harness.
Fake functions have been moved from tests/unit/harness into tests/harness, but they depend on src/bpfilter (e.g. bf_cgen_xxx()). Move the fake functions back into tests/unit, and keep the fake file functions in tests/harness.
Add autosectionlabel Sphinx extension to link to anchors in a page. Rename docs/developers/fronts/nftables.rst to nft.rst to reflect the actual front-end name and prevent anchor clash with docs/usage/nftables.rst.
Add the bf_test_prog object which represents a BPF program. It will be used in end-to-end tests to interact with a program generated by bpfilter and execute test runs.
Creating a chain requires a bf_hook_opts object which can be cumbersome to construct: strings must be copied and used_opts needs to be updated for each option. Add a new helper to easily create a bf_hook_opts object from a list of (option, value) pairs.
Create a new e2e target to build and run end-to-end tests. End-to-end test will configure bpfilter with a specific chain and use BPF_PROG_TEST_RUN to ensure the BPF program behaves as expected.
qdeslandes
force-pushed
the
e2e_harness
branch
from
772ed06
to
e7a8e42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After refactoring the unit tests harness (#161) and creating a shared testing harness in
tests/harness(#163), this is the final PR to create an end-to-end testing target!The end-to-end tests will be used to validate the bytecode generated by
bpfilterby:bpfilterdaemon locallyEnd-to-end tests rely on
cmocka(like the unit tests) to run the test suite. Helper functions defined in previous PR are used to manage the daemon and define the filtering rules.