IPv6 prefix filtering #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In IPv6, network mask doesn't exist, prefixes are used instead. Fix the documentation by using the correct terminology.
bf_test_packet encapsulate a packet data and its size. It simplifies passing around a packet.
IPv6 addresses filtering is buggy as prefixes don't work as expected. Fix ip6.(s|d)addr filtering with prefix by using an array of uint8_t to store the address and the prefix, to avoid endianess errors. This change is not expected to have any runtime impact on the BPF program as the processing is done from the daemon.
Create a Python script to generate the packets using Scapy at build time. The resulting header file is included in the test sources.
End-to-end tests should not (yet) be built by default.
qdeslandes
force-pushed
the
ip6_prefix
branch
from
58ffa4b
to
cfdc0fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix IPv6 addresses filtering with network prefix by resolving endianness issues and applying the network prefix mask to both the rule's IP address and the packet's IP address. Add end-to-end tests to ensure this matcher won't break anymore.