Simplify the end-to-end tests harness #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove bf_chain_get() and replace it with bf_test_chain_get() which doesn't allow custom hook options. bf_test_chain_get() will automatically configure the hook options so the generate BPF program is not attached and has a name prefixed with `bf_e2e_`. Because bf_test_chain_get() generates a program name suffixed with random characters, rand() is used. 2 clang-tidy checks have been disabled as rand() is not cryptographically secure, but it's fine for this use case.
bf_test_prog_get() is used to get a reference to a BPF program loaded into the kernel. The user must call bf_cli_set_chain() beforehand for bf_test_prog_get() to succeed. However, end-to-end tests will always perform the same step: - Call bf_cli_set_chain() to generate and load the BPF program - Call bf_test_prog_get() to get a reference to the generated program Modify bf_test_prog_get() to take a chain as parameter and send it to the daemon, then, returns a reference to the program as a result. This change reduces the boilerplate required to perform the actual test, and ensure the user only have access to relevant high-level concepts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the test harness to reduce the boilerplate required to define a new end-to-end test:
bf_hook_optsstructure, as all the end-to-end test programs should have the same options: do not attach, custom generated name, and a random cgroup/ifindex value.bf_test_prog_get()to send the chain to the daemon: all the end-to-end tests defined will send the chain to the daemon and get a reference to the corresponding BPF program.bf_test_prog_get()has been modified to perform those 2 steps at once, as there is no reason for the end-to-end tests to customize this behaviour.