[apple_asset_catalog] Include Product Type in AcTool Args

[ydxia]

Currently, building Messages extensions with buck will not generate the Messages app icon correctly. This is because in order to do so, actool needs to know what product type it is creating an asset catalog + app icon for.

This change funnels the product type from apple_bundle into AppleAssetCatalog and AcToolStep so that actool is called with --product-type <product type> (needs to be com.apple.product-type.app-extension.messages for Messages extensions).

[facebook-github-bot]

Hi @ydxia!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[ydxia]

@v-jizhang can you take a look? 🙏

[v-jizhang]

@ydxia We are working on a change in buck open source, please see the announcement #2401. And we will get back to you soon. Thanks you.

[ydxia]

For my understanding, should changes target the dev branch then? The announcement references changes made by the "Facebook’s Build Infra team" for dev; does this impact how external contributions are merged?

[v-jizhang]

Yes, all PRs will be reviewed and merged here in the master branch. Only selected PRs can be ported to dev.

[ydxia]

ok so dev will contain experimental changes to infrastructure whereas bug fixes should still go to master?

[v-jizhang]

Bug fixes should be ported to dev too.

[ydxia]

hi - just pinging again here to get a sense of what the expected workflow is and if there's anything needed from my side. Thanks!

[v-jizhang]

Your PR looks good to me but we 're working on an Open Source plan. Thank you!