Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Create buck_tool.py #2722

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Create buck_tool.py #2722

wants to merge 1 commit into from

Conversation

EdTice
Copy link

@EdTice EdTice commented Aug 19, 2022

Setting argv[0] to "buck" on Windows violates the normal convention where argv[0] should be the application name. This might convenient for finding buck-related tasks in process-explorer but it comes with the drawback of making argv[0] not reliable for process identification

Setting argv[0] to "buck" on Windows violates the normal convention where argv[0] should be the application name.  This might convenient for finding buck-related tasks in process-explorer but it comes with the drawback of making argv[0] not reliable for process identification
@facebook-github-bot
Copy link
Contributor

Hi @EdTice!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants