avoid re-evaluating to know if a package has changed #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69714496 |
AishwaryaSivaraman
force-pushed
the
export-D69714496
branch
from
02169cb to
e74c2e5
Compare
AishwaryaSivaraman
added a commit
to AishwaryaSivaraman/buck2
that referenced
this pull request
Feb 19, 2025
Summary: Context: Adding a random file to `fbcode/` does some recomputation in the graph that leads to 40s build time in the incremental case. When `fbcode/BUCK` is a dep, this is unavoidable since you need to traverse the entire graph to understand if you need to recompute anything. However, in the case of some targets like `//aps_models/ads/gmp:launcher_with_publish` `fbcode/BUCK` is not a dep, but since we check for nearby package files for the entire graph, we end up spending more time. #thanks jakobdegen for helping me figure out what causes additional 35s computation in dice when we add files to fbcode/ Reviewed By: JakobDegen Differential Revision: D69714496
|
This pull request was exported from Phabricator. Differential Revision: D69714496 |
Summary: Context: Adding a random file to `fbcode/` does some recomputation in the graph that leads to 40s build time in the incremental case. When `fbcode/BUCK` is a dep, this is unavoidable since you need to traverse the entire graph to understand if you need to recompute anything. However, in the case of some targets like `//aps_models/ads/gmp:launcher_with_publish` `fbcode/BUCK` is not a dep, but since we check for nearby package files for the entire graph, we end up spending more time. #thanks jakobdegen for helping me figure out what causes additional 35s computation in dice when we add files to fbcode/ Reviewed By: JakobDegen Differential Revision: D69714496
AishwaryaSivaraman
force-pushed
the
export-D69714496
branch
from
e74c2e5 to
3fdcc16
Compare
|
This pull request was exported from Phabricator. Differential Revision: D69714496 |
|
This pull request has been merged in 28bd815. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context: Adding a random file to
fbcode/does some recomputation in the graph that leads to 40s build time in the incremental case.When
fbcode/BUCKis a dep, this is unavoidable since you need to traverse the entire graph to understand if you need to recompute anything. However, in the case of some targets like//aps_models/ads/gmp:launcher_with_publishfbcode/BUCKis not a dep, but since we check for nearby package files for the entire graph, we end up spending more time.#thanks jakobdegen for helping me figure out what causes additional 35s computation in dice when we add files to fbcode/
Reviewed By: JakobDegen
Differential Revision: D69714496