-
-
Notifications
You must be signed in to change notification settings - Fork 26.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add experimental module federation support #11125
Conversation
Hi @hasanayan! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
if anyone is interested in testing things in an app, just put these in package.json dependencies and hit npm install.
you'll need a file named .modulefederationrc.js which exports ModuleFederationPlugin parameters as json.
|
@ianschmitz @mrmckeb can we get this into wp5 branch before #11201 merged into main? |
@hasanayan Im wondering why only 7 checks have run, should be 15 (seems like integration tests have not run) (I would be pro merging this, would like to review and qa locally - feature is marked experimental and only active if configured so low risk/impact) |
@raix I have no idea why there are missing checks, should I re-create the source branch from create-react-app/wp5 ? |
Opened another PR (#11241) for the same purpose since some checks are missing in this one |
I re-enabled @raix's code to enable module-federation and added the necessary changes to the webpack config. Tested the changes by making the same modifications using craco in apps that both run as standalone or remote apps and it works fine.
With this PR, to enable Module Federation, you'll need a file named .modulefederationrc.js which exports ModuleFederationPlugin parameters as json.