-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(algolia): upgrade to the new major #10672
base: main
Are you sure you want to change the base?
Conversation
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks @millotp Since this is a new version, where can I check the breaking changes that potentially affect us? This seems a bit risky to release this as a minor/patch release.
That's how it affects our internal code. But we also expose some things as part of a public API through themeConfig options: https://docusaurus.io/docs/search#connecting-algolia I'm particularly worried of possible breaking changes to this type that we expose through import type { SearchOptions } from '@algolia/client-search'; Are there any to be aware of? Apart from TS APIs, are there behavior changes to be aware of? For example, different defaults? |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Pre-flight checklist
Motivation
Algolia has released a new major version of the javascript search client.
Since DocSearch is now using the new version, we can also upgrade the
docusaurus-theme-search-algolia
package to use the latest version of the js client and of DocSearch.There are a few changes to do in the code to accommodate the new version but nothing breaking, it's mostly around types and imports.
Test Plan
The existing tests are enough to test that every works, I also tried the local website and the search is working, with the user agent containing the latest version.
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs