fix(bundler): allow CSS nesting by default, restore postcss-preset-env #10680
+650
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Size Change: +1.01 kB (+0.01%) Total Size: 11.2 MB
ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: +692 B (+0.01%) Total Size: 11.7 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #9303
CSS nesting should be downgraded according to browserslist config with
postcss-preset-env(which includesautoprefixer)Note: Docusaurus Faster (LightningCSS instead of PostCSS) already supports CSS nesting, so this only aligns the 2 implementations and fix a long-standing postcss bug.
I have no idea why postcss-preset-env has been removed in this old PR, but it's more useful than just autoprefixing: #4355
Test Plan
DOCUSAURUS_SLOWER=true yarn build:website:fast && yarn serve:websiteTest links
https://deploy-preview-10680--docusaurus-2.netlify.app/