Skip to content

Commit

Permalink
Add missing scopes to rust.Name
Browse files Browse the repository at this point in the history
Summary:
These are handled by the generator.
Const is not handled, which is probably not intended.

Reviewed By: Imxset21

Differential Revision: D68337010

fbshipit-source-id: 18d96d854f181a12ae6f78e4082f79b6463f77d9
  • Loading branch information
iahs authored and facebook-github-bot committed Jan 17, 2025
1 parent 9faf8de commit 4459753
Show file tree
Hide file tree
Showing 5 changed files with 81 additions and 64 deletions.
5 changes: 3 additions & 2 deletions thrift/annotation/rust.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,15 @@ namespace py.asyncio facebook_thrift_asyncio.annotation.rust
namespace go thrift.annotation.rust
namespace py thrift.annotation.rust

// This is scope.Definition minus scope.Const
@scope.Function
@scope.EnumValue
@scope.Enum
@scope.Struct
@scope.Structured
@scope.Field
@scope.Typedef
@scope.Union
@scope.Service
@scope.Interaction
struct Name {
// # `rust.Name`
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public static function getAllStructuredAnnotations()[write_props]: \TStructAnnot
shape(
)
),
'\facebook\thrift\annotation\Struct' => \facebook\thrift\annotation\Struct::fromShape(
'\facebook\thrift\annotation\Structured' => \facebook\thrift\annotation\Structured::fromShape(
shape(
)
),
Expand All @@ -107,11 +107,11 @@ public static function getAllStructuredAnnotations()[write_props]: \TStructAnnot
shape(
)
),
'\facebook\thrift\annotation\Union' => \facebook\thrift\annotation\Union::fromShape(
'\facebook\thrift\annotation\Service' => \facebook\thrift\annotation\Service::fromShape(
shape(
)
),
'\facebook\thrift\annotation\Service' => \facebook\thrift\annotation\Service::fromShape(
'\facebook\thrift\annotation\Interaction' => \facebook\thrift\annotation\Interaction::fromShape(
shape(
)
),
Expand Down
Loading

0 comments on commit 4459753

Please sign in to comment.