This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
Removed bolts-applinks dependency not in use #2580
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As explained in this Issue when running checks to see if Jetifier is needed to compile any given app using Flipper, it complain due to the dependency on
com.parse.bolts:bolts-applinks:1.4.0
.Bolts has already fixed the AndroidX migration in version
1.5.0
but it has never been published (Issue)After checking the code i realized flipper is only using
bolts-tasks
inFrescoFlipperPlugin
(code).bolts-applinks
depends onbolts-tasks
but not the other way around, so we can safely remove this dependency.Changelog
Test Plan
Tests
./gradlew :android:test
and make sure they passSmoke test
fresco-plugin
android/sample
compiles and runsImages
pluginLoad Fresco Image