Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Removed bolts-applinks dependency not in use #2580

Closed
wants to merge 1 commit into from

Conversation

obsantos
Copy link

@obsantos obsantos commented Jul 9, 2021

Summary

As explained in this Issue when running checks to see if Jetifier is needed to compile any given app using Flipper, it complain due to the dependency on com.parse.bolts:bolts-applinks:1.4.0.

Scanning com.parse.bolts:bolts-applinks:1.4.0
 Absoulute path: /....../bolts-applinks-1.4.0.jar
 Graphs to this dependency:
 +---com.facebook.flipper:flipper:0.74.0
     +---com.parse.bolts:bolts-applinks:1.4.0

> Task :canISayByeByeJetifier FAILED

Bolts has already fixed the AndroidX migration in version 1.5.0 but it has never been published (Issue)

After checking the code i realized flipper is only using bolts-tasks in FrescoFlipperPlugin (code).

bolts-applinks depends on bolts-tasks but not the other way around, so we can safely remove this dependency.

Changelog

  • Removed dependency on bolts-applinks not in use

Test Plan

Tests

  • Run unit tests ./gradlew :android:test and make sure they pass

Smoke test fresco-plugin

  • Make sure android/sample compiles and runs
  • In the Flipper desktop app enable Images plugin
  • In the Android sample app tap on Load Fresco Image
  • Verify in desktop app that the image shows correctly and the plugin works

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jul 9, 2021
@facebook-github-bot
Copy link
Contributor

@jknoxville has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@jknoxville merged this pull request in 98f56a3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants