fbsource//xplat/graphics/igl/public/src/igl/vulkan [A] [A]

Reviewed By: nlutsenko Differential Revision: D67289339 fbshipit-source-id: bcfd3790386fc95873ee6572255e431afff1cacf
facebook · Dec 17, 2024 · 2a5c7f5 · 2a5c7f5
1 parent 7441463
commit 2a5c7f5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 9 deletions.
diff --git a/src/igl/vulkan/Common.cpp b/src/igl/vulkan/Common.cpp
@@ -7,7 +7,6 @@
 
 #include "Common.h"
 
-#include <cstdio>
 #include <cstdlib>
 
 // clang-format off

diff --git a/src/igl/vulkan/Common.h b/src/igl/vulkan/Common.h
@@ -220,7 +220,7 @@ void ensureShaderModule(IShaderModule* sm);
 
 /// @brief Implements the igl::IDepthStencilState interface
 struct DepthStencilState final : public IDepthStencilState {
-  explicit DepthStencilState(const DepthStencilStateDesc& desc) : desc_(desc) {}
+  explicit DepthStencilState(DepthStencilStateDesc desc) : desc_(std::move(desc)) {}
   const DepthStencilStateDesc desc_;
 };
 

diff --git a/src/igl/vulkan/PlatformDevice.h b/src/igl/vulkan/PlatformDevice.h
@@ -15,9 +15,7 @@
 struct AHardwareBuffer;
 #endif // defined(IGL_ANDROID_HWBUFFER_SUPPORTED)
 
-namespace igl {
-
-namespace vulkan {
+namespace igl::vulkan {
 
 class Device;
 
@@ -82,5 +80,4 @@ class PlatformDevice : public IPlatformDevice {
   std::shared_ptr<ITexture> nativeDepthTexture_;
 };
 
-} // namespace vulkan
-} // namespace igl
+} // namespace igl::vulkan
diff --git a/src/igl/vulkan/SamplerState.h b/src/igl/vulkan/SamplerState.h
@@ -14,8 +14,6 @@
 namespace igl::vulkan {
 
 class Device;
-class PipelineState;
-class VulkanContext;
 
 /**
  * @brief Encapsulates a VulkanSampler class and its descriptor, along with a vulkan::Device for