Skip to content

Commit

Permalink
igl | Add SPIRV-Headers to fix GitHub Actions (#54)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: #54

Test Plan:
https://github.com/facebook/igl/actions

Updated dependencies: https://www.internalfb.com/intern/wiki/IGL/IGL_CMake_CI_Builds/

Reviewed By: EricGriffith

Differential Revision: D51513206

Pulled By: corporateshark

fbshipit-source-id: 1f751d2003c722f1202d17af048f32e13438b16e
  • Loading branch information
corporateshark authored and facebook-github-bot committed Nov 22, 2023
1 parent eb04676 commit 7a24f36
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/c-cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,8 +108,8 @@ jobs:
- name: Prepare Vulkan SDK
uses: humbletim/[email protected]
with:
vulkan-query-version: 1.3.204.0
vulkan-components: Vulkan-Headers, Vulkan-Loader
vulkan-query-version: 1.3.268.0
vulkan-components: Vulkan-Headers, Vulkan-Loader, SPIRV-Headers
vulkan-use-cache: true

- name: Get the number of CPU cores
Expand Down
Empty file modified deploy_content.py
100644 → 100755
Empty file.
Empty file modified deploy_deps.py
100644 → 100755
Empty file.
1 change: 1 addition & 0 deletions src/igl/vulkan/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ target_link_libraries(IGLVulkan PUBLIC fmt)

target_include_directories(IGLVulkan PUBLIC "${IGL_ROOT_DIR}/third-party/deps/src/volk")
target_include_directories(IGLVulkan PUBLIC "${IGL_ROOT_DIR}/third-party/deps/src/vma/include")
target_include_directories(IGLVulkan PUBLIC "${IGL_ROOT_DIR}/third-party/deps/src/SPIRV-Headers/include")

if(WIN32)
add_definitions("-DVK_USE_PLATFORM_WIN32_KHR=1")
Expand Down
4 changes: 0 additions & 4 deletions src/igl/vulkan/util/SpvReflection.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@

#include <igl/vulkan/util/SpvReflection.h>

#if defined(IGL_CMAKE_BUILD) && !IGL_PLATFORM_LINUX
#include <spirv-headers/spirv.h>
#else
#include <spirv/unified1/spirv.h>
#endif // IGL_CMAKE_BUILD

#define IGL_COMMON_SKIP_CHECK
#include <igl/Assert.h>
Expand Down
8 changes: 8 additions & 0 deletions third-party/bootstrap-deps.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@
"revision": "12.1.0"
}
},
{
"name": "SPIRV-Headers",
"source": {
"type": "git",
"url": "https://github.com/KhronosGroup/SPIRV-Headers.git",
"revision": "cca08c63cefa129d082abca0302adcb81610b465"
}
},
{
"name": "tinyobjloader",
"source": {
Expand Down

0 comments on commit 7a24f36

Please sign in to comment.