Skip to content

Commit

Permalink
[yojson] open builtins
Browse files Browse the repository at this point in the history
Summary:
In upgrading to OCaml 5.2, yojson needs to be upgraded. The target version (0.16) does not open automatically the module with yojson builtins, so the build breaks with errors of the form
```
File "src/IR/Typ.ml", line 125, characters 17-21:
125 |   ; is_volatile: bool }
                       ^^^^
Error: Unbound value yojson_of_bool
```
This diff opens the builtins module via dune where needed.

Reviewed By: geralt-encore

Differential Revision:
D66297493

Privacy Context Container: L1208441

fbshipit-source-id: fbf4c54e52a3255ac8d75a6d58e7bd45666ad046
  • Loading branch information
ngorogiannis authored and facebook-github-bot committed Nov 21, 2024
1 parent 61c1eea commit ed53866
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 6 deletions.
4 changes: 3 additions & 1 deletion infer/src/IR/dune
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
-open
ATDGenerated
-open
IBase))
IBase
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries core zarith ppx_show.runtime IStdlib ATDGenerated IBase)
(preprocess
(pps ppx_compare ppx_hash ppx_show ppx_sexp_conv ppx_yojson_conv inferppx)))
Expand Down
4 changes: 3 additions & 1 deletion infer/src/absint/dune
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
-open
ATDGenerated
-open
IBase))
IBase
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries core ppx_show.runtime IStdlib ATDGenerated IBase IR)
(preprocess
(pps ppx_compare ppx_hash ppx_show ppx_yojson_conv)))
Expand Down
4 changes: 3 additions & 1 deletion infer/src/backend/dune
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,9 @@
-open
Concurrency
-open
Labs))
Labs
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries
core
memtrace
Expand Down
4 changes: 3 additions & 1 deletion infer/src/base/dune
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
-open
ATDGenerated
-open
OpenSource))
OpenSource
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries
cmdliner
core
Expand Down
4 changes: 3 additions & 1 deletion infer/src/checkers/dune
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@
-open
BO
-open
Pulselib))
Pulselib
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries
base64
core
Expand Down
4 changes: 3 additions & 1 deletion infer/src/pulse/dune
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@
-open
Absint
-open
Topllib))
Topllib
-open
Ppx_yojson_conv_lib.Yojson_conv.Primitives))
(libraries
core
iter
Expand Down

0 comments on commit ed53866

Please sign in to comment.