Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Font styles not applying to text in table cells #7076

Open
ivailop7 opened this issue Jan 21, 2025 · 1 comment
Open

Regression: Font styles not applying to text in table cells #7076

ivailop7 opened this issue Jan 21, 2025 · 1 comment
Labels
selection tables Relates to Lexical Tables

Comments

@ivailop7
Copy link
Collaborator

Lexical: 0.23.1

After doing a git bisect, the following PR: #6981 introduced a regression, where upon selecting table cells and changing the font styles: color, background-color, etc are no longer applied.

Bug:

Screen.Recording.2025-01-21.at.22.22.21.mov
@ivailop7 ivailop7 added tables Relates to Lexical Tables selection labels Jan 21, 2025
@etrepum
Copy link
Collaborator

etrepum commented Jan 22, 2025

Looks like it's probably the if (!$isRangeSelection(selection)) { check in that function. Probably that function should get a little more complicated and check the anchor/focus to deal with partial node selections only when it's a range selection rather than just returning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selection tables Relates to Lexical Tables
Projects
None yet
Development

No branches or pull requests

2 participants