Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Cannot apply text styles to TableSelection #7089

Closed
patrick-atticus opened this issue Jan 24, 2025 · 1 comment
Closed

Bug: Cannot apply text styles to TableSelection #7089

patrick-atticus opened this issue Jan 24, 2025 · 1 comment

Comments

@patrick-atticus
Copy link
Contributor

patrick-atticus commented Jan 24, 2025 •
edited
Loading

Lexical version: v0.23.1

Steps To Reproduce

In the playground:

  1. Create a table
  2. Add text to one or more cells
  3. Select multiple cells, creating a TableSelection
  4. Attempt to change the text color/background color/font size
  5. No styles are applied
CleanShot.2025-01-24.at.15.46.42.mp4

The current behavior

No text styles are applied

This is due to an early return in $forEachSelectedTextNode that requires a RangeSelection.

The expected behavior

$patchStyleText should merge the new styles when provided with a TableSelection

Impact of fix

Limits the usability of tables
@etrepum
Copy link
Collaborator

etrepum commented Jan 24, 2025

Duplicate of #7076

@etrepum etrepum marked this as a duplicate of #7076 Jan 24, 2025
@etrepum etrepum closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@etrepum @patrick-atticus