Fix how client id is set inside client metadata

Summary:
I noticed this during a different investigation - https://fburl.com/scuba/buck2_builds/ftzax112.

`id` within client metadata is a special field that will be picked up by the `client` column in buck2 datasets. `client_id` is not treated this way and so these clients will be missed when someone does client-based filtering on buck2 data.

Post about client metadata for reference: https://fburl.com/workplace/spvca8ua

Reviewed By: zsol

Differential Revision: D63546060

fbshipit-source-id: 47321f942b85c318a3a5ac334de63c520e7fcdad

client/commands/pyre_language_server.py

@@ -726,7 +726,7 @@ async def _query_buck_for_type_errors(
                 "--reuse-current-config",
                 "--preemptible=ondifferentstate",
                 "--oncall=pyre",
-                "--client-metadata=client_id=pyre.ide",
+                "--client-metadata=id=pyre.ide",
                 f"--write-build-id={build_id_file.name}",
                 "prelude//python/typecheck/batch_files.bxl:run",
                 f"@{argfile.name}",
@@ -865,7 +865,7 @@ async def _get_files_for_type_checker(
                 "bxl",
                 "--reuse-current-config",
                 "--oncall=pyre",
-                "--client-metadata=client_id=pyre.ide",
+                "--client-metadata=id=pyre.ide",
                 "prelude//python/sourcedb/typing_query.bxl:typing_query",
                 f"@{argfile.name}",
             ]