Fix Pyre path find when init Pysa #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthaud
requested changes
Aug 16, 2023
arthaud
approved these changes
Aug 16, 2023
|
@arthaud has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Thanks for the contribution! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 6, 2023
Summary: **Pre-submission checklist** - [x] I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running `pip install -r requirements-dev.txt && pre-commit install` - [x] `pre-commit run` Sorry about I generated this typo in #772 should be `expected` but not `excepted`. Pull Request resolved: #796 Test Plan: N/A Reviewed By: kinto0 Differential Revision: D50021836 Pulled By: inseokhwang fbshipit-source-id: a0ff5be12d4cb0d4be6e37b8e648de95c7bc9e65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
This PR fixed #710.
Test Plan
Pysa should init with no error message
Couldn't infer filter directory, skipping filter import to sapp.