Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the object instead of the exception type #780

Conversation

WangGithubUser
Copy link
Contributor

Pre-submission checklist

  • I've ran the linters locally and fixed lint errors related to the files I modified in this PR. You can install the linters by running pip install -r requirements-dev.txt && pre-commit install
  • pre-commit run

Summary

We should provide raise the object instance, but not the type.

Test Plan

N/A

@WangGithubUser
Copy link
Contributor Author

Seems this PR isn't necessary, I will close it now...Python will auto change the exception type to the instance object.

@WangGithubUser WangGithubUser deleted the raise_exception_obj_instead_class branch August 20, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants