Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the KeyboardAvoidingView component #29224

Conversation

ayushjainrksh
Copy link
Contributor

@ayushjainrksh ayushjainrksh commented Jun 25, 2020

Fixes MLH-Fellowship#47

Summary

The PR is part of an effort to update the code comments to match the current documentation on the React Native website. The project is a part of MLH fellowship program and involves automatic generation of the website docs from code comments and flow types as the end result.

To learn more about the project you can visit the project wiki:

Link to the documentation(the source of truth):

Changes

  • Update the title and prop description from docs.
  • Remove unnecessary * from the code comments.
  • Add Snack player example specified in the docs to the code comments.
  • Remove default values from description and add it to @default annotation.
  • Cap comments to 80 characters.

Changelog

[Internal]

Test Plan

All changes are made to the code comments and thus there is no need for testing.

Reviewed by @jevakallio

* Update the title and prop description from docs.
* Remove asterisks from the comments.
* Add snackplayer example with example annotation.
* Add inherit annotation for inherited component.
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 25, 2020
@analysis-bot
Copy link

analysis-bot commented Jun 25, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 829440 n/a

Base commit: 499b021

@analysis-bot
Copy link

analysis-bot commented Jun 25, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,760,785 -352,108
android hermes armeabi-v7a 6,423,738 -339,704
android hermes x86 7,147,287 -383,662
android hermes x86_64 7,037,183 -382,893
android jsc arm64-v8a 8,934,366 -338,059
android jsc armeabi-v7a 8,589,686 -325,425
android jsc x86 8,763,984 -354,579
android jsc x86_64 9,339,498 -354,388

Base commit: 499b021

@charlesbdudley charlesbdudley self-assigned this Aug 13, 2021
@charlesbdudley
Copy link
Contributor

charlesbdudley commented Aug 16, 2021

Thanks for this contribution, @ayushjainrksh, and apologies for not getting around to it until now. This MLH-Fellowship project is not currently being worked on so we're going to close this PR to focus on active ones. If you feel this is an error or if you'd like to pick this up again, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the KeyboardAvoidingView component
4 participants