Feed React tracing into Instruments signposts API #45169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
Base commit: 3fc7ebb |
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
lyahdav
force-pushed
the
export-D58895740
branch
from
4ca6ec3
to
ebb407a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
Jun 28, 2024
Summary: Pull Request resolved: facebook#45169 This is a follow-up to D56280451 where I made all SystraceSection calls feed into the Instruments signposts API. This will additionally do the same for all calls to nativeTraceBeginSection/nativeTraceEndSection from JSITracing.cpp. Changelog: [Internal] Differential Revision: D58895740
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
Jun 28, 2024
Summary: Pull Request resolved: facebook#45169 This is a follow-up to D56280451 where I made all SystraceSection calls feed into the Instruments signposts API. This will additionally do the same for all calls to nativeTraceBeginSection/nativeTraceEndSection from JSITracing.cpp. Changelog: [Internal] Differential Revision: D58895740
lyahdav
force-pushed
the
export-D58895740
branch
from
ebb407a
to
a993373
Compare
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
lyahdav
added a commit
to lyahdav/react-native
that referenced
this pull request
Jul 2, 2024
Summary: Pull Request resolved: facebook#45169 This is a follow-up to D56280451 where I made all SystraceSection calls feed into the Instruments signposts API. This will additionally do the same for all calls to nativeTraceBeginSection/nativeTraceEndSection from JSITracing.cpp. Changelog: [Internal] Differential Revision: D58895740
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
Summary: Pull Request resolved: facebook#45169 This is a follow-up to D56280451 where I made all SystraceSection calls feed into the Instruments signposts API. This will additionally do the same for all calls to nativeTraceBeginSection/nativeTraceEndSection from JSITracing.cpp. Changelog: [Internal] Differential Revision: D58895740
|
This pull request was exported from Phabricator. Differential Revision: D58895740 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is a follow-up to D56280451 where I made all SystraceSection calls feed into the Instruments signposts API. This will additionally do the same for all calls to nativeTraceBeginSection/nativeTraceEndSection from JSITracing.cpp.
Changelog: [Internal]
Differential Revision: D58895740