Set up experiment to fix incorrect state updates in smooth scroll animations on Android #45237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D59233069 |
Base commit: ffd0b39 |
…tes on Android Differential Revision: D59233070
…mations on Android (facebook#45237) Summary: Pull Request resolved: facebook#45237 Changelog: [internal] This creates a feature flag to test a fix for an incorrect state update dispatched to Fabric when using smooth scroll animations. Specifically, when starting a smooth scroll animation from X to Y, the scroll view would set the state to Y, and then all the range from X to Y again. For example, the sequence of state updates when smooth scrolling from 0 to 5 would be `0 -> 5 -> 1 -> 2 -> 3 -> 4 -> 5`, which is obviously incorrect. This flag prevents setting the final value before it's actually reached. Reviewed By: javache Differential Revision: D59233069
|
This pull request was exported from Phabricator. Differential Revision: D59233069 |
rubennorte
force-pushed
the
export-D59233069
branch
from
17a55a9
to
47e183a
Compare
|
This pull request has been merged in e35a2f4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
This creates a feature flag to test a fix for an incorrect state update dispatched to Fabric when using smooth scroll animations.
Specifically, when starting a smooth scroll animation from X to Y, the scroll view would set the state to Y, and then all the range from X to Y again. For example, the sequence of state updates when smooth scrolling from 0 to 5 would be
0 -> 5 -> 1 -> 2 -> 3 -> 4 -> 5, which is obviously incorrect.This flag prevents setting the final value before it's actually reached.
Differential Revision: D59233069