Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new HostTargetMetadata fields (Android Bridgeless) #45249

Closed
wants to merge 2 commits into from

Conversation

huntie
Copy link
Member

@huntie huntie commented Jul 2, 2024

Summary:
Follows D58288489, D58415181.

Implements the remaining HostTargetMetadata fields, sent by the debugger on ReactNativeApplication.metadataUpdated, on Android Bridgeless.

This will be used to display details such as the app name and React Native version in the debugger frontend.

Changelog: [Internal]

Differential Revision: D59271755

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Jul 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59271755

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59271755

huntie added a commit to huntie/react-native that referenced this pull request Jul 2, 2024
…k#45249)

Summary:
Pull Request resolved: facebook#45249

Follows D58288489, D58415181.

Implements the remaining `HostTargetMetadata` fields, sent by the debugger on `ReactNativeApplication.metadataUpdated`, on **Android Bridgeless**.

This will be used to display details such as the app name and React Native version in the debugger frontend.

Changelog: [Internal]

Differential Revision: D59271755
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59271755

huntie added a commit to huntie/react-native that referenced this pull request Jul 3, 2024
…k#45249)

Summary:
Pull Request resolved: facebook#45249

Follows D58288489, D58415181.

Implements the remaining `HostTargetMetadata` fields, sent by the debugger on `ReactNativeApplication.metadataUpdated`, on **Android Bridgeless**.

This will be used to display details such as the app name and React Native version in the debugger frontend.

Changelog: [Internal]

Differential Revision: D59271755
Summary:
Follows D58288489

Changelog: [Internal]

Differential Revision: D58415181
…k#45249)

Summary:
Pull Request resolved: facebook#45249

Follows D58288489, D58415181.

Implements the remaining `HostTargetMetadata` fields, sent by the debugger on `ReactNativeApplication.metadataUpdated`, on **Android Bridgeless**.

This will be used to display details such as the app name and React Native version in the debugger frontend.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D59271755
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D59271755

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 9da07d7.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants