Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add badgeTopMargin param to NewAppScreen Header #47708

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alanleedev
Copy link
Contributor

Summary:
In order to properly support edge-to-edge on Android, we need to be able to configure the top margin of the HermesBadge within the Header.
Add badgeTopMargin prop to configure the margin.

Changelog: [Internal]

Differential Revision: D66140673

Summary:
NewAppScreen should be removed from public API test

Changelog: [Internal]

Differential Revision: D66165484
Summary:
In order to properly support edge-to-edge on Android, we need to be able to configure the top margin of the `HermesBadge` within the `Header`.
Add badgeTopMargin prop to configure the margin.

Changelog: [Internal]

Differential Revision: D66140673
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D66140673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants