Add missing Android-only props to ImageProps #47719
Open
+86
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There is Android code that supports remapping `defaultSrc` -> `defaultSource` for `ImageNativeComponent`. The docs reference this prop as `defaultSource`: https://reactnative.dev/docs/next/image#defaultsource It is not referenced as `defaultSrc` anywhere. Let's unify it as `defaultSource` across both platforms. Changelog: [Internal] Differential Revision: D65819218
Summary: `defaultSource` is defined as a single `ImageSource` in docs (https://reactnative.dev/docs/next/image#defaultsource) but its type is a vector of `ImageSource`s in `ImageProps.h`. This diff changes its C++ type to just `ImageSource`. Technically, this is a breaking change, however I don't think folks should directly access `ImageProps` outside of `RCTImageComponentView.mm` Moreover, this prop is actually not implemented in Fabric, so this change should have no practical effect. Changelog: [Internal] Facebook T208171435 - [RN][Fabric][iOS] Implement defaultSource support for Image Differential Revision: D65821570
Summary: There is a subset of `ImageProps` that are used by Android but not used by iOS. They were missing in the `ImageProps.h`. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props. This diff adds those props to the corresponding C++ type. This should have no practical effect for both platforms. Changelog: [Internal] Differential Revision: D65426569
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65426569 |
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: There is a subset of `ImageProps` that are used by Android but not used by iOS. They were missing in the `ImageProps.h`. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props. This diff adds those props to the corresponding C++ type. This should have no practical effect for both platforms. Changelog: [Internal] Reviewed By: javache Differential Revision: D65426569
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: There is a subset of `ImageProps` that are used by Android but not used by iOS. They were missing in the `ImageProps.h`. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props. This diff adds those props to the corresponding C++ type. This should have no practical effect for both platforms. Changelog: [Internal] Reviewed By: javache Differential Revision: D65426569
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: There is a subset of `ImageProps` that are used by Android but not used by iOS. They were missing in the `ImageProps.h`. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props. This diff adds those props to the corresponding C++ type. This should have no practical effect for both platforms. Changelog: [Internal] Reviewed By: javache Differential Revision: D65426569
dmytrorykun
added a commit
to dmytrorykun/react-native
that referenced
this pull request
Nov 19, 2024
Summary: There is a subset of `ImageProps` that are used by Android but not used by iOS. They were missing in the `ImageProps.h`. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props. This diff adds those props to the corresponding C++ type. This should have no practical effect for both platforms. Changelog: [Internal] Reviewed By: javache Differential Revision: D65426569
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is a subset of
ImagePropsthat are used by Android but not used by iOS. They were missing in theImageProps.h. It was fine when they were only consumed by the Android mounting layer. But it becomes a problem if we want to write some shared C++ code based on those props.This diff adds those props to the corresponding C++ type.
This should have no practical effect for both platforms.
Changelog: [Internal]
Differential Revision: D65426569