Update YGNodeStyleGetGap to return YGValue #47973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66513236 |
NickGerleman
force-pushed
the
export-D66513236
branch
from
f384b73 to
c71eacb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66513236 |
Summary: Gap can be styled using both `points` and `percentages`, but YGNodeStyleGetGap currently returns a float value. To maintain alignment with the `padding` and `margin` functionalities and allow it to be handled in bridging code, this function has been updated to return YGValue. X-link: facebook/yoga#1753 Reviewed By: joevilches Differential Revision: D66513236 Pulled By: NickGerleman
NickGerleman
force-pushed
the
export-D66513236
branch
from
c71eacb to
8332648
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66513236 |
|
@NickGerleman merged this pull request in 331d99a. |
|
This pull request was successfully merged by @heoblitz in 331d99a When will my fix make it into a release? | How to file a pick request? |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 9, 2024
Summary: X-link: facebook/react-native#47973 Gap can be styled using both `points` and `percentages`, but YGNodeStyleGetGap currently returns a float value. To maintain alignment with the `padding` and `margin` functionalities and allow it to be handled in bridging code, this function has been updated to return YGValue. X-link: facebook/yoga#1753 Reviewed By: joevilches Differential Revision: D66513236 Pulled By: NickGerleman fbshipit-source-id: b7110855c037f20780f031f22a945bde4446687d
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Dec 9, 2024
Summary: X-link: facebook/react-native#47973 Gap can be styled using both `points` and `percentages`, but YGNodeStyleGetGap currently returns a float value. To maintain alignment with the `padding` and `margin` functionalities and allow it to be handled in bridging code, this function has been updated to return YGValue. Pull Request resolved: #1753 Reviewed By: joevilches Differential Revision: D66513236 Pulled By: NickGerleman fbshipit-source-id: b7110855c037f20780f031f22a945bde4446687d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Gap can be styled using both
pointsandpercentages, but YGNodeStyleGetGap currently returns a float value.To maintain alignment with the
paddingandmarginfunctionalities and allow it to be handled in bridging code, this function has been updated to return YGValue.X-link: facebook/yoga#1753
Reviewed By: joevilches
Differential Revision: D66513236
Pulled By: NickGerleman