Asset ImageFetcher thread correctness in DEBUG builds #54487
+76
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86678354. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Changelog: [Internal] Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
2 times, most recently
from
00e0b36 to
3707642
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
from
3707642 to
f62afe6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
from
f62afe6 to
ce71cc2
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Pull Request resolved: facebook#54487 Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
from
ce71cc2 to
fe250e7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 11, 2025
Summary: Pull Request resolved: facebook#54487 Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
2 times, most recently
from
5d0b324 to
bb7e31e
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Nov 12, 2025
Summary: Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
…#54486) Summary: This brings back another version of batching image request JNI calls. Previous attempts crashed in edge cases Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86676643
Summary: Changelog: [Internal] Reviewed By: lenaic Differential Revision: D86678354
christophpurrer
force-pushed
the
export-D86678354
branch
from
bb7e31e to
a3da2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Changelog: [Internal]
Differential Revision: D86678354