Skip to content

Commit

Permalink
[ci] Cleanup more references to circleci
Browse files Browse the repository at this point in the history
ghstack-source-id: b8028680b48b3f572a80f740ea66271b6e12e3de
Pull Request resolved: #30509
  • Loading branch information
poteto committed Jul 29, 2024
1 parent 530ddac commit 0c67419
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 21 deletions.
2 changes: 1 addition & 1 deletion ReactVersions.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const ReactVersion = '19.0.0';
// choose to change it to "alpha", "beta", "rc", etc.
//
// It only affects the label used in the version string. To customize the
// npm dist tags used during publish, refer to .circleci/config.yml.
// npm dist tags used during publish, refer to .github/workflows/runtime_prereleases_*.yml.
const canaryChannelLabel = 'rc';

// If the canaryChannelLabel is "rc", the build pipeline will use this to build
Expand Down
2 changes: 1 addition & 1 deletion dangerfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ ${significantResults.join('\n')}
writeFileSync('sizebot-message.md', message);
markdown(
'The size diff is too large to display in a single comment. ' +
`The [CircleCI job](${process.env.CIRCLE_BUILD_URL}) contains an artifact called 'sizebot-message.md' with the full message.`
`The GitHub action for this pull request contains an artifact called 'sizebot-message.md' with the full message.`
);
} else {
markdown(message);
Expand Down
2 changes: 1 addition & 1 deletion scripts/release/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ If this is your first time running the release scripts, go to the `scripts/relea
The release process consists of several phases, each one represented by one of the scripts below.

A typical release cycle goes like this:
1. When a commit is pushed to the React repo, [Circle CI](https://circleci.com/gh/facebook/react/) will build all release bundles and run unit tests against both the source code and the built bundles.
1. When a commit is pushed to the React repo, [GitHub Actions](https://github.com/facebook/react/actions) will build all release bundles and run unit tests against both the source code and the built bundles.
2. Each weekday, an automated CI cron job publishes prereleases to the `next` and `experimental` channels, from tip of the main branch.
1. You can also [trigger an automated prerelease via the command line](#trigger-an-automated-prerelease), instead of waiting until the next time the cron job runs.
2. For advanced cases, you can [**manually prepare and publish to the `next` channel**](#publishing-release) using the [`prepare-release-from-ci`](#prepare-release-from-ci) and [`publish`](#publish) scripts; or to the [**`experimental` channel**](#publishing-an-experimental-release) using the same scripts (but different build artifacts).
Expand Down
18 changes: 1 addition & 17 deletions scripts/release/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,6 @@ const extractCommitFromVersionNumber = version => {
return match[2];
};

const getArtifactsList = async buildID => {
const headers = {};
const {CIRCLE_CI_API_TOKEN} = process.env;
if (CIRCLE_CI_API_TOKEN != null) {
headers['Circle-Token'] = CIRCLE_CI_API_TOKEN;
}
const jobArtifactsURL = `https://circleci.com/api/v1.1/project/github/facebook/react/${buildID}/artifacts`;
const jobArtifacts = await fetch(jobArtifactsURL, {headers});
return jobArtifacts.json();
};

const getBuildInfo = async () => {
const cwd = join(__dirname, '..', '..');

Expand All @@ -86,10 +75,6 @@ const getBuildInfo = async () => {
? `0.0.0-experimental-${commit}-${dateString}`
: `0.0.0-${commit}-${dateString}`;

// Only available for Circle CI builds.
// https://circleci.com/docs/2.0/env-vars/
const buildNumber = process.env.CIRCLE_BUILD_NUM;

// React version is stored explicitly, separately for DevTools support.
// See updateVersionsForNext() below for more info.
const packageJSON = await readJson(
Expand All @@ -99,7 +84,7 @@ const getBuildInfo = async () => {
? `${packageJSON.version}-experimental-${commit}-${dateString}`
: `${packageJSON.version}-${commit}-${dateString}`;

return {branch, buildNumber, checksum, commit, reactVersion, version};
return {branch, checksum, commit, reactVersion, version};
};

const getChecksumForCurrentRevision = async cwd => {
Expand Down Expand Up @@ -275,7 +260,6 @@ module.exports = {
addDefaultParamValue,
confirm,
execRead,
getArtifactsList,
getBuildInfo,
getChecksumForCurrentRevision,
getCommitFromCurrentBuild,
Expand Down
1 change: 0 additions & 1 deletion scripts/tasks/eslint.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ const runESLint = require('../eslint');

async function main() {
console.log('Linting all files...');
// https://circleci.com/docs/2.0/env-vars/#circleci-environment-variable-descriptions
if (!process.env.CI) {
console.log('Hint: run `yarn linc` to only lint changed files.');
}
Expand Down

0 comments on commit 0c67419

Please sign in to comment.